feat(cli): load project from .chainloop.yaml#3065
Open
waveywaves wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/cli/cmd/config.go">
<violation number="1" location="app/cli/cmd/config.go:165">
P2: Added `.chainloop` `organization` field is unused, causing a silent no-op that can mislead users.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| type DotChainloopConfig struct { | ||
| ProjectVersion string `yaml:"projectVersion"` | ||
| Project string `yaml:"project"` | ||
| Organization string `yaml:"organization"` |
There was a problem hiding this comment.
P2: Added .chainloop organization field is unused, causing a silent no-op that can mislead users.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At app/cli/cmd/config.go, line 165:
<comment>Added `.chainloop` `organization` field is unused, causing a silent no-op that can mislead users.</comment>
<file context>
@@ -161,4 +161,6 @@ func isDir(filename string) bool {
type DotChainloopConfig struct {
ProjectVersion string `yaml:"projectVersion"`
+ Project string `yaml:"project"`
+ Organization string `yaml:"organization"`
}
</file context>
waveywaves
force-pushed
the
feat/chainloop-yaml-org-project
branch
from
2abca03 to
50ce228
Compare
Contributor
Author
|
@migmartri @jiparis Ready for review. Extends |
waveywaves
force-pushed
the
feat/chainloop-yaml-org-project
branch
2 times, most recently
from
299cc6b to
c78092b
Compare
waveywaves
force-pushed
the
feat/chainloop-yaml-org-project
branch
from
c78092b to
458d7c7
Compare
waveywaves
force-pushed
the
feat/chainloop-yaml-org-project
branch
from
458d7c7 to
e1ace05
Compare
Allow attestation init to use the project configured in .chainloop.yaml when --project is omitted, while preserving CLI flag precedence. Fixes: chainloop-dev#3063 Assisted-by: pi Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
waveywaves
force-pushed
the
feat/chainloop-yaml-org-project
branch
from
e1ace05 to
d2a5d38
Compare
waveywaves
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chainloop attestation initto load the project name from.chainloop.yamlwhen--projectis omitted.Fixes #3063
Assisted-by: pi